feat(client): allow omitting params object when none required

README.md

@@ -51,8 +51,7 @@ import org.onebusaway.models.CurrentTimeRetrieveResponse
 // Configures using the `ONEBUSAWAY_API_KEY` environment variable
 val client: OnebusawaySdkClient = OnebusawaySdkOkHttpClient.fromEnv()
 
-val params: CurrentTimeRetrieveParams = CurrentTimeRetrieveParams.builder().build()
-val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve(params)
+val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve()
 ```
 
 ## Client configuration
@@ -128,8 +127,7 @@ import org.onebusaway.models.CurrentTimeRetrieveResponse
 // Configures using the `ONEBUSAWAY_API_KEY` environment variable
 val client: OnebusawaySdkClient = OnebusawaySdkOkHttpClient.fromEnv()
 
-val params: CurrentTimeRetrieveParams = CurrentTimeRetrieveParams.builder().build()
-val currentTime: CurrentTimeRetrieveResponse = client.async().currentTime().retrieve(params)
+val currentTime: CurrentTimeRetrieveResponse = client.async().currentTime().retrieve()
 ```
 
 Or create an asynchronous client from the beginning:
@@ -143,8 +141,7 @@ import org.onebusaway.models.CurrentTimeRetrieveResponse
 // Configures using the `ONEBUSAWAY_API_KEY` environment variable
 val client: OnebusawaySdkClientAsync = OnebusawaySdkOkHttpClientAsync.fromEnv()
 
-val params: CurrentTimeRetrieveParams = CurrentTimeRetrieveParams.builder().build()
-val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve(params)
+val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve()
 ```
 
 The asynchronous client supports the same options as the synchronous one, except most methods are [suspending](https://kotlinlang.org/docs/coroutines-guide.html).
@@ -226,9 +223,7 @@ To set a custom timeout, configure the method call using the `timeout` method:
 import org.onebusaway.models.CurrentTimeRetrieveParams
 import org.onebusaway.models.CurrentTimeRetrieveResponse
 
-val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve(
-  params, RequestOptions.builder().timeout(Duration.ofSeconds(30)).build()
-)
+val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve(RequestOptions.builder().timeout(Duration.ofSeconds(30)).build())
 ```
 
 Or configure the default for all method calls at the client level:
@@ -356,9 +351,7 @@ Or configure the method call to validate the response using the `responseValidat
 import org.onebusaway.models.CurrentTimeRetrieveParams
 import org.onebusaway.models.CurrentTimeRetrieveResponse
 
-val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve(
-  params, RequestOptions.builder().responseValidation(true).build()
-)
+val currentTime: CurrentTimeRetrieveResponse = client.currentTime().retrieve(RequestOptions.builder().responseValidation(true).build())
 ```
 
 Or configure the default for all method calls at the client level:

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/models/AgenciesWithCoverageListParams.kt

@@ -30,6 +30,8 @@ private constructor(
 
     companion object {
 
+        fun none(): AgenciesWithCoverageListParams = builder().build()
+
         fun builder() = Builder()
     }
 

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/models/ConfigRetrieveParams.kt

@@ -27,6 +27,8 @@ private constructor(
 
     companion object {
 
+        fun none(): ConfigRetrieveParams = builder().build()
+
         fun builder() = Builder()
     }
 

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/models/CurrentTimeRetrieveParams.kt

@@ -27,6 +27,8 @@ private constructor(
 
     companion object {
 
+        fun none(): CurrentTimeRetrieveParams = builder().build()
+
         fun builder() = Builder()
     }
 

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/services/async/AgenciesWithCoverageServiceAsync.kt

@@ -13,7 +13,14 @@ interface AgenciesWithCoverageServiceAsync {
      * center of their coverage area.
      */
     suspend fun list(
-        params: AgenciesWithCoverageListParams,
+        params: AgenciesWithCoverageListParams = AgenciesWithCoverageListParams.none(),
         requestOptions: RequestOptions = RequestOptions.none(),
     ): AgenciesWithCoverageListResponse
+
+    /**
+     * Returns a list of all transit agencies currently supported by OneBusAway along with the
+     * center of their coverage area.
+     */
+    suspend fun list(requestOptions: RequestOptions): AgenciesWithCoverageListResponse =
+        list(AgenciesWithCoverageListParams.none(), requestOptions)
 }

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/services/async/ConfigServiceAsync.kt

@@ -10,7 +10,11 @@ interface ConfigServiceAsync {
 
     /** config */
     suspend fun retrieve(
-        params: ConfigRetrieveParams,
+        params: ConfigRetrieveParams = ConfigRetrieveParams.none(),
         requestOptions: RequestOptions = RequestOptions.none(),
     ): ConfigRetrieveResponse
+
+    /** config */
+    suspend fun retrieve(requestOptions: RequestOptions): ConfigRetrieveResponse =
+        retrieve(ConfigRetrieveParams.none(), requestOptions)
 }

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/services/async/CurrentTimeServiceAsync.kt

@@ -10,7 +10,11 @@ interface CurrentTimeServiceAsync {
 
     /** current-time */
     suspend fun retrieve(
-        params: CurrentTimeRetrieveParams,
+        params: CurrentTimeRetrieveParams = CurrentTimeRetrieveParams.none(),
         requestOptions: RequestOptions = RequestOptions.none(),
     ): CurrentTimeRetrieveResponse
+
+    /** current-time */
+    suspend fun retrieve(requestOptions: RequestOptions): CurrentTimeRetrieveResponse =
+        retrieve(CurrentTimeRetrieveParams.none(), requestOptions)
 }

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/services/blocking/AgenciesWithCoverageService.kt

@@ -13,7 +13,14 @@ interface AgenciesWithCoverageService {
      * center of their coverage area.
      */
     fun list(
-        params: AgenciesWithCoverageListParams,
+        params: AgenciesWithCoverageListParams = AgenciesWithCoverageListParams.none(),
         requestOptions: RequestOptions = RequestOptions.none(),
     ): AgenciesWithCoverageListResponse
+
+    /**
+     * Returns a list of all transit agencies currently supported by OneBusAway along with the
+     * center of their coverage area.
+     */
+    fun list(requestOptions: RequestOptions): AgenciesWithCoverageListResponse =
+        list(AgenciesWithCoverageListParams.none(), requestOptions)
 }

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/services/blocking/ConfigService.kt

@@ -10,7 +10,11 @@ interface ConfigService {
 
     /** config */
     fun retrieve(
-        params: ConfigRetrieveParams,
+        params: ConfigRetrieveParams = ConfigRetrieveParams.none(),
         requestOptions: RequestOptions = RequestOptions.none(),
     ): ConfigRetrieveResponse
+
+    /** config */
+    fun retrieve(requestOptions: RequestOptions): ConfigRetrieveResponse =
+        retrieve(ConfigRetrieveParams.none(), requestOptions)
 }

onebusaway-sdk-kotlin-core/src/main/kotlin/org/onebusaway/services/blocking/CurrentTimeService.kt

@@ -10,7 +10,11 @@ interface CurrentTimeService {
 
     /** current-time */
     fun retrieve(
-        params: CurrentTimeRetrieveParams,
+        params: CurrentTimeRetrieveParams = CurrentTimeRetrieveParams.none(),
         requestOptions: RequestOptions = RequestOptions.none(),
     ): CurrentTimeRetrieveResponse
+
+    /** current-time */
+    fun retrieve(requestOptions: RequestOptions): CurrentTimeRetrieveResponse =
+        retrieve(CurrentTimeRetrieveParams.none(), requestOptions)
 }

onebusaway-sdk-kotlin-core/src/test/kotlin/org/onebusaway/services/blocking/AgenciesWithCoverageServiceTest.kt

@@ -6,7 +6,6 @@ import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 import org.onebusaway.TestServerExtension
 import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient
-import org.onebusaway.models.AgenciesWithCoverageListParams
 
 @ExtendWith(TestServerExtension::class)
 class AgenciesWithCoverageServiceTest {
@@ -19,8 +18,7 @@ class AgenciesWithCoverageServiceTest {
                 .apiKey("My API Key")
                 .build()
         val agenciesWithCoverageService = client.agenciesWithCoverage()
-        val agenciesWithCoverageListResponse =
-            agenciesWithCoverageService.list(AgenciesWithCoverageListParams.builder().build())
+        val agenciesWithCoverageListResponse = agenciesWithCoverageService.list()
         println(agenciesWithCoverageListResponse)
     }
 }

onebusaway-sdk-kotlin-core/src/test/kotlin/org/onebusaway/services/blocking/ConfigServiceTest.kt

@@ -6,7 +6,6 @@ import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 import org.onebusaway.TestServerExtension
 import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient
-import org.onebusaway.models.ConfigRetrieveParams
 
 @ExtendWith(TestServerExtension::class)
 class ConfigServiceTest {
@@ -19,7 +18,7 @@ class ConfigServiceTest {
                 .apiKey("My API Key")
                 .build()
         val configService = client.config()
-        val configRetrieveResponse = configService.retrieve(ConfigRetrieveParams.builder().build())
+        val configRetrieveResponse = configService.retrieve()
         println(configRetrieveResponse)
     }
 }

onebusaway-sdk-kotlin-core/src/test/kotlin/org/onebusaway/services/blocking/CurrentTimeServiceTest.kt

@@ -6,7 +6,6 @@ import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 import org.onebusaway.TestServerExtension
 import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient
-import org.onebusaway.models.CurrentTimeRetrieveParams
 
 @ExtendWith(TestServerExtension::class)
 class CurrentTimeServiceTest {
@@ -19,8 +18,7 @@ class CurrentTimeServiceTest {
                 .apiKey("My API Key")
                 .build()
         val currentTimeService = client.currentTime()
-        val currentTimeRetrieveResponse =
-            currentTimeService.retrieve(CurrentTimeRetrieveParams.builder().build())
+        val currentTimeRetrieveResponse = currentTimeService.retrieve()
         println(currentTimeRetrieveResponse)
     }
 }