Unregistering commands/regions/... when reloading Scratch or Story or JS

[vorburger]

see https://github.com/OASIS-learn-study/minecraft-storeys-maker/blob/develop/docs/testing.md (from #305)

[vorburger]

ch.vorburger.minecraft.storeys.Unregisterable was my original design idea about this. It currently has 3 implementations:

1. Commands
2. Conditions ("when inside")
3. Right-click event registrations

[vorburger]

The ActionsConsumer holds Unregisterable in its conditionRegistrations, a Map, and unregister() them when its stop().

What seems to be missing here is to also do this when "reloading" (or removing) scrits... I'm not sure yet where/how to do this.

The LocationToolListener also has something related.

[vorburger]

What seems to be missing here is to also do this when "reloading" (or removing) scrits... I'm not sure yet where/how to do this.

ActionsConsumer is missing something like a String source argument on its handle(Message<JsonObject> message).

If we had that, we could unregister() things "by source".

[vorburger]

@edewit while staring at our observable-wrapper.ts API, I noticed that we already return Promise<Registration> for event handlers.

At the very end of observable-wrapper.ts there is something missing which we would have to implement for this to really work, I think.

If that were fully implemented, and if the Node.JS "project runner" (?) would have some way to externally invoke an unregister() on the registration of e.g. test.js, then this could work. You could try that? (I think I would probably struggle to "connect everything together" correctly, from JS via Vert.x into Java.)

However this would require anyone who write JS to "do the right thing". What would IMHO be "even nicer" is if the JS script didn't have to deal with the registration explicitly, but if it was somehow more automatic. I want to further explore that, in the context of the more general #295 approach.