Simplify DerivationBuildingGoal, but with goto
#13865
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
derivation-building-goal-simplify
branch
2 times, most recently
from
03d7584 to
31eb33d
Compare
Ericson2314
force-pushed
the
derivation-building-goal-simplify
branch
from
31eb33d to
f1ab63b
Compare
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
derivation-building-goal-simplify
branch
from
f1ab63b to
ae930f9
Compare
|
🎉 All dependencies have been resolved ! |
|
@Ericson2314 please rebase. |
Ericson2314
changed the title
DerivationBuildingGoal in a number of waysDerivationBuildingGoal with goto
Ericson2314
changed the title
DerivationBuildingGoal with gotoDerivationBuildingGoal, but with goto
The resulting `goto` is not so nice, but it is still worth doing this so we can turn more fields into local variables.
Ericson2314
force-pushed
the
derivation-building-goal-simplify
branch
from
ae930f9 to
4f4bc51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See each commit for details.
Context
Not in earlier PRs because the
gotois unsavory. Perhaps I will have other goal-splitting to do that will side-step this issue.Depends on #13905
Depends on #13906
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.