Skip to content

Conversation

ArangoGutierrez
Copy link
Collaborator

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Node Feature Discovery (NFD) version from v0.6.0/v0.16.6 to v0.17.3 across both static YAML deployment and Helm chart dependencies.

  • Updates NFD container images in static deployment configuration
  • Updates NFD Helm chart dependency version
  • Aligns all NFD references to use the same v0.17.3 version

Reviewed Changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

File Description
deployments/static/nfd.yaml Updates container image tags from v0.6.0 to v0.17.3
deployments/helm/nvidia-device-plugin/Chart.yaml Updates NFD Helm dependency from v0.16.6 to v0.17.3

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general question: In the context of the GPU Operator we have discussed listing NFD as an EXPLICIT prerequisite instead of including the subcharts. Is this something that makes sense for the device plugin too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually mention this file in any of our documentation. Can we rather remove it?

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the static deployment for NFD to further reduce the maintenance burden for this repo.

elezar and others added 2 commits September 15, 2025 12:31
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@elezar elezar merged commit b0508d6 into NVIDIA:main Sep 15, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants