-
Notifications
You must be signed in to change notification settings - Fork 733
Bump NFD Helm to v0.17.3 #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NFD Helm to v0.17.3 #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the Node Feature Discovery (NFD) version from v0.6.0/v0.16.6 to v0.17.3 across both static YAML deployment and Helm chart dependencies.
- Updates NFD container images in static deployment configuration
- Updates NFD Helm chart dependency version
- Aligns all NFD references to use the same v0.17.3 version
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
deployments/static/nfd.yaml | Updates container image tags from v0.6.0 to v0.17.3 |
deployments/helm/nvidia-device-plugin/Chart.yaml | Updates NFD Helm dependency from v0.16.6 to v0.17.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general question: In the context of the GPU Operator we have discussed listing NFD as an EXPLICIT prerequisite instead of including the subcharts. Is this something that makes sense for the device plugin too?
deployments/static/nfd.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually mention this file in any of our documentation. Can we rather remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the static deployment for NFD to further reduce the maintenance burden for this repo.
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
No description provided.