[None][infra] update feature_combination_matrix of disaggregated and chunked prefill #6661
Conversation
📝 WalkthroughWalkthroughThis change updates compatibility entries in the feature combination matrix documentation, marking "Chunked Prefill," "KV Cache Reuse," and "Slide Window Attention" as compatible with "Disaggregated Serving." It refactors the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/source/torch/features/feature_combination_matrix.md (1)
12-12: Minor consistency nit – double-check for any remaining “NO” capitalisation.
You fixed the casing here, but if any other rows/columns still contain an uppercase “NO”, consider normalising them to “No” for stylistic consistency throughout the table.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/source/torch/features/feature_combination_matrix.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: in tensorrt-llm testing, it's common to have both cli flow tests (test_cli_flow.py) and pytorch api ...
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
docs/source/torch/features/feature_combination_matrix.md
🔇 Additional comments (1)
docs/source/torch/features/feature_combination_matrix.md (1)
9-9: Update accurately reflects unsupported “Chunked Prefill × Disaggregated Serving”.
The change to “No” aligns the matrix with the currenttrtllm-servelimitation (enable_chunked_prefillflag not supported). Looks good.
|
PR_Github #14281 [ run ] triggered by Bot |
|
/bot run |
|
PR_Github #14296 [ run ] triggered by Bot |
|
PR_Github #14281 [ run ] completed with state |
|
PR_Github #14296 [ run ] completed with state |
|
/bot run |
|
PR_Github #14299 [ run ] triggered by Bot |
|
PR_Github #14299 [ run ] completed with state |
|
/bot run |
|
PR_Github #14345 [ run ] triggered by Bot |
|
/bot run |
|
PR_Github #14416 [ run ] triggered by Bot |
|
PR_Github #14345 [ run ] completed with state |
leslie-fang25
changed the title
|
PR_Github #14416 [ run ] completed with state |
|
/bot run |
|
PR_Github #14424 [ run ] triggered by Bot |
|
PR_Github #14424 [ run ] completed with state |
|
@leslie-fang25 Does this PR need to be cherry-picked into release/1.0 branch? |
leslie-fang25
force-pushed
the
leslie/update_disaggregated_feature_combination
branch
from
352c768 to
cd6dfa1
Compare
|
/bot run |
|
PR_Github #15393 [ run ] triggered by Bot |
|
PR_Github #15393 [ run ] completed with state |
leslie-fang25
force-pushed
the
leslie/update_disaggregated_feature_combination
branch
from
cd6dfa1 to
1cc91c3
Compare
|
/bot run |
|
PR_Github #15404 [ run ] triggered by Bot |
|
PR_Github #15404 [ run ] completed with state |
|
/bot run |
|
PR_Github #15495 [ run ] triggered by Bot |
|
PR_Github #15495 [ run ] completed with state |
leslie-fang25
force-pushed
the
leslie/update_disaggregated_feature_combination
branch
2 times, most recently
from
bb370fd to
1fbd151
Compare
|
/bot run |
|
PR_Github #15670 [ run ] triggered by Bot |
leslie-fang25
force-pushed
the
leslie/update_disaggregated_feature_combination
branch
from
1fbd151 to
1e71ba2
Compare
|
/bot run |
|
PR_Github #15738 [ run ] triggered by Bot |
|
PR_Github #15670 [ run ] completed with state |
|
PR_Github #15738 [ run ] completed with state |
|
/bot run |
…unked prefill Signed-off-by: leslie-fang25 <[email protected]>
leslie-fang25
force-pushed
the
leslie/update_disaggregated_feature_combination
branch
from
1e71ba2 to
aa5e86c
Compare
|
/bot run |
|
PR_Github #15775 [ run ] triggered by Bot |
|
PR_Github #15776 [ run ] triggered by Bot |
|
PR_Github #15775 [ run ] completed with state |
|
PR_Github #15776 [ run ] completed with state |
Summary by CodeRabbit
Summary by CodeRabbit
Description
This PR mainly update the feature combination matrix of
disaggregated:disaggregatedwithchunked_prefill: verified and added the test case in this PRdisaggregatedwithkv cache reuse: verified by checkingcache_hit_rateTensorRT-LLM/tensorrt_llm/_torch/pyexecutor/py_executor.py
Line 573 in 413a83f
disaggregatedwithSWA: test case already existing astest_disaggregated_serving.py::TestGemma3_1BInstruct::test_auto_dtype.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.