[fix] Catch inference failures in trtllm-bench
#5841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Ullman Argov <[email protected]>
Signed-off-by: Omer Ullman Argov <[email protected]>
Signed-off-by: Omer Ullman Argov <[email protected]>
|
/bot run |
|
PR_Github #11287 [ run ] triggered by Bot |
|
PR_Github #11287 [ run ] completed with state |
achartier
approved these changes
Jul 8, 2025
FrankD412
approved these changes
Jul 9, 2025
zhou-yuxin
pushed a commit
to zhou-yuxin/TensorRT-LLM
that referenced
this pull request
Jul 15, 2025
Signed-off-by: Omer Ullman Argov <[email protected]> Signed-off-by: Yuxin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds several checks that ensures
trtllm-benchdoes not hang indefinitely if an exception is thrown during inference:asynciotasks are checked for errors when done, and the manager is stopped if an error occurs.CancelErrors are caught for a cleaner traceback.py_executor.pyto check for sampling failures.