Popup: Don't reposition if only size has changed #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolyMeilex
force-pushed
the
popup-dont-reposition-on-resize
branch
from
2fd494f to
90a3959
Compare
PolyMeilex
added a commit
to PolyMeilex/nvim.init
that referenced
this pull request
Sep 9, 2024
Introduces needless complexity (and bugs MunifTanjim/nui.nvim#384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to resize the popup without causing repositioning. So changing only the size of a popup that's positioned relative to cursor position, will cause it to move to potentially new cursor position.
So this is an attempt to update only the size of the window if position related properties have not changed during the relayout.