feat: expand attribute scheme to allow combining meshdata #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Improvement
pollend
force-pushed
the
feat/add-combine-operation-standard-mesh-data
branch
from
b07c797 to
a3340ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a way to combine mesh data from a different mesh. I use the the last position in the buffer to determine where the last vertex was so I can stitch the mesh together. Any fields that are unused in both meshes are kept empty else I allocate out to that limit.
I want to go with something less opinionated. We have a couple factories but their use cases are limited and are used in very limited scenarios. my thought is to introduce a set of base primitives plus some useful operations and the rest will be up to the discretion of the developer.