feat: subscription payment options integration #35929
Merged
+989
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change contents based on payment method - show usdt usdc and musd only with balance
- add todo on shield plan and type
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (4 files, +36 -0)
📜 @MetaMask/policy-reviewers (4 files, +36 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +36 -0)
|
tuna1207
commented
Sep 17, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tuna1207
commented
Sep 17, 2025
tuna1207
commented
Sep 17, 2025
| "@metamask/snaps-utils>validate-npm-package-name": true | ||
| } | ||
| }, | ||
| "@metamask/subscription-controller": { |
There was a problem hiding this comment.
This package, @metamask/subscription-controller is new controller being used for subscription feature
cc: @MetaMask/policy-reviewers
| "@metamask/snaps-utils>validate-npm-package-name": true | ||
| } | ||
| }, | ||
| "@metamask/subscription-controller": { |
There was a problem hiding this comment.
This package, @metamask/subscription-controller is new controller being used for subscription feature
cc: @MetaMask/policy-reviewers
| "@metamask/snaps-utils>validate-npm-package-name": true | ||
| } | ||
| }, | ||
| "@metamask/subscription-controller": { |
There was a problem hiding this comment.
This package, @metamask/subscription-controller is new controller being used for subscription feature
cc: @MetaMask/policy-reviewers
| "@metamask/snaps-utils>validate-npm-package-name": true | ||
| } | ||
| }, | ||
| "@metamask/subscription-controller": { |
There was a problem hiding this comment.
This package, @metamask/subscription-controller is new controller being used for subscription feature
cc: @MetaMask/policy-reviewers
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [4f2d9c8]
UI Startup Metrics (1208 ± 55 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 263 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 41 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 215 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 123 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 25 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 311ms | Sum of p95 exceeds: 502.8ms Sum of all benchmark exceeds: 813.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [49f15b7]
UI Startup Metrics (1196 ± 56 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1407 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 285 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 92 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 5 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 290ms | Sum of p95 exceeds: 507.8ms Sum of all benchmark exceeds: 797.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
naugtur
approved these changes
Sep 17, 2025
chaitanyapotti
approved these changes
Sep 17, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
chaitanyapotti
deleted the
feat/subscription-payment-options-integration
branch
metamaskbot
added
the
release-13.5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
#shield-planpageScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist