feat(stable-sync): add write permissions to the stable sync workflow #35896

alucardzom · 2025-09-12T13:56:21Z

Description

The process was raising an error due to lack of permissions for pushing a new stable-sync branch. With this change we will fix this, and the process will create a new sync branch every time the stable branch receives an update.

Example:
https://github.com/MetaMask/metamask-extension/actions/runs/17677410077/job/50242954756

Changelog

CHANGELOG entry: null

Related issues

Fixes: #35690

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

branch

github-actions · 2025-09-12T13:56:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

We tested it and it runs well

gauthierpetetin

LGTM

metamaskbot · 2025-09-12T15:02:42Z

📊 Page Load Benchmark Results

Current Commit: d8fb5d7 | Date: 9/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±70ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 742ms (±69ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	70ms	1.02s	1.33s	1.28s	1.33s
domContentLoaded	742ms	69ms	704ms	1.01s	950ms	1.01s
firstPaint	77ms	12ms	60ms	180ms	84ms	180ms
firstContentfulPaint	77ms	12ms	60ms	180ms	84ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-12T15:02:53Z

Builds ready [d8fb5d7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1231 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1095	1408	70	1270	1359
			load	1069	950	1243	67	1111	1203
			domContentLoaded	1062	947	1234	66	1105	1193
			domInteractive	18	13	42	6	17	38
			firstPaint	701	75	1239	439	1091	1199
			backgroundConnect	245	232	268	7	249	257
			firstReactRender	23	16	41	5	24	34
			getState	13	4	43	7	17	25
			initialActions	6	0	90	11	6	18
			loadScripts	824	709	1006	66	867	955
			setupStore	9	6	19	2	10	14
	Webpack	Home	uiStartup	1999	1493	2562	270	2163	2488
			load	1599	1214	1966	206	1747	1921
			domContentLoaded	1591	1207	1955	205	1741	1911
			domInteractive	18	12	91	14	15	54
			firstPaint	166	65	394	65	184	321
			backgroundConnect	34	17	354	45	29	49
			firstReactRender	80	37	325	59	77	280
			getState	43	4	305	88	14	286
			initialActions	5	2	22	4	6	13
			loadScripts	1588	1205	1945	203	1738	1899
			setupStore	15	6	290	28	14	24
Firefox	Browserify	Home	uiStartup	1444	1257	1858	110	1508	1678
			load	1242	1082	1468	77	1300	1382
			domContentLoaded	1242	1082	1468	77	1300	1382
			domInteractive	109	33	302	50	117	231
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	38	22	133	22	38	91
			firstReactRender	28	23	55	5	30	37
			getState	8	2	79	10	7	25
			initialActions	4	0	120	12	4	8
			loadScripts	1213	1062	1442	76	1269	1362
			setupStore	11	5	107	14	9	24
	Webpack	Home	uiStartup	1565	1355	2110	174	1655	1929
			load	1341	1153	1726	146	1444	1645
			domContentLoaded	1341	1153	1726	146	1443	1644
			domInteractive	111	32	375	73	104	305
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	20	119	11	37	45
			firstReactRender	43	31	57	5	46	52
			getState	8	3	234	23	6	11
			initialActions	3	0	38	4	3	7
			loadScripts	1318	1130	1702	147	1423	1619
			setupStore	9	5	31	5	9	22

Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1204 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1194 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1199 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 257 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 44 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2489 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 286 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1444 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1678 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 231 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 305 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 351ms | Sum of p95 exceeds: 687.8ms
Sum of all benchmark exceeds: 1038.8ms

metamaskbot · 2025-09-12T16:22:44Z

📊 Page Load Benchmark Results

Current Commit: d8fb5d7 | Date: 9/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±53ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±50ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±27ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	53ms	1.01s	1.49s	1.06s	1.49s
domContentLoaded	723ms	50ms	702ms	1.16s	750ms	1.16s
firstPaint	78ms	27ms	56ms	340ms	84ms	340ms
firstContentfulPaint	78ms	27ms	56ms	340ms	84ms	340ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-12T16:22:53Z

Builds ready [d8fb5d7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1240 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1240	1095	1396	58	1283	1334
			load	1069	954	1198	55	1103	1171
			domContentLoaded	1061	941	1189	55	1096	1166
			domInteractive	18	13	45	6	18	37
			firstPaint	721	141	1181	412	1080	1132
			backgroundConnect	250	233	352	13	253	261
			firstReactRender	24	17	92	9	25	39
			getState	14	5	47	7	19	30
			initialActions	6	1	122	13	5	20
			loadScripts	819	702	949	55	853	921
			setupStore	10	6	30	4	10	19
	Webpack	Home	uiStartup	1965	1474	2487	270	2167	2388
			load	1556	1194	1859	194	1683	1831
			domContentLoaded	1548	1184	1851	193	1677	1816
			domInteractive	17	12	84	13	14	44
			firstPaint	154	60	343	53	177	261
			backgroundConnect	41	13	436	66	29	169
			firstReactRender	89	34	338	77	79	323
			getState	36	5	324	78	14	279
			initialActions	7	2	155	15	6	16
			loadScripts	1544	1182	1839	192	1673	1805
			setupStore	23	6	295	53	15	38
Firefox	Browserify	Home	uiStartup	1411	1200	2351	149	1467	1642
			load	1222	1053	2166	122	1280	1357
			domContentLoaded	1222	1053	2166	122	1280	1357
			domInteractive	102	33	308	48	111	222
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	20	141	20	37	82
			firstReactRender	27	22	58	4	29	32
			getState	7	3	178	18	6	10
			initialActions	3	1	17	3	3	11
			loadScripts	1194	1036	2141	121	1247	1333
			setupStore	12	4	223	23	8	29
	Webpack	Home	uiStartup	1530	1352	1946	144	1624	1806
			load	1306	1145	1628	121	1394	1542
			domContentLoaded	1306	1145	1627	121	1394	1542
			domInteractive	102	33	315	61	98	281
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	98	10	36	41
			firstReactRender	43	31	62	5	46	51
			getState	5	3	16	2	6	8
			initialActions	4	1	53	6	3	9
			loadScripts	1284	1127	1605	122	1374	1523
			setupStore	9	5	77	10	8	14

Benchmark value 1241 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 250 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 42 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 170 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1412 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 309ms | Sum of p95 exceeds: 620.8ms
Sum of all benchmark exceeds: 929.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

feat(stable-sync): test github-tool pending permission for creating a

fa2afe3

branch

metamaskbot added the team-dev-ops DevOps team label Sep 12, 2025

github-actions bot added the size-XS label Sep 12, 2025

chore: test with PR token

bbf7917

github-actions bot added size-S and removed size-XS labels Sep 12, 2025

alucardzom added 2 commits September 12, 2025 16:17

chore: set permissions

70791dc

chore: last test with restored token permissions

15dde65

github-actions bot added size-XS and removed size-S labels Sep 12, 2025

chore: restore the file with only the changes needed

69ebc68

We tested it and it runs well

alucardzom changed the title ~~feat(stable-sync): test github-tool pending permission for creating a~~ feat(stable-sync): add write permissions to the stable sync workflow Sep 12, 2025

alucardzom added the skip-e2e skip E2E test jobs label Sep 12, 2025

Merge branch 'main' into ale/fix-forbidden-error-stable-sync

d8fb5d7

alucardzom marked this pull request as ready for review September 12, 2025 14:36

gauthierpetetin approved these changes Sep 12, 2025

View reviewed changes

makemesteaks approved these changes Sep 12, 2025

View reviewed changes

alucardzom added the skip-e2e-quality-gate label Sep 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(stable-sync): add write permissions to the stable sync workflow #35896

feat(stable-sync): add write permissions to the stable sync workflow #35896

alucardzom commented Sep 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

gauthierpetetin left a comment

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

Uh oh!

feat(stable-sync): add write permissions to the stable sync workflow #35896

Are you sure you want to change the base?

feat(stable-sync): add write permissions to the stable sync workflow #35896

Conversation

alucardzom commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

gauthierpetetin left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Sep 12, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

metamaskbot commented Sep 12, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 12, 2025

Uh oh!

Uh oh!

alucardzom commented Sep 12, 2025 •

edited

Loading