Skip to content

Conversation

ErwanSimonetti
Copy link
Contributor

No description provided.

@ErwanSimonetti ErwanSimonetti marked this pull request as draft January 21, 2025 10:24
Copy link
Contributor

mergify bot commented Jan 21, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • label = skip changelog
    • -title ~= ^feat
    • label = need changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@ErwanSimonetti ErwanSimonetti force-pushed the comprehensive-diff branch 2 times, most recently from e62ae65 to ebddf32 Compare March 4, 2025 15:27
@ErwanSimonetti ErwanSimonetti changed the title feat(diff): started sql compare diff function feat: get_diff function returning human-readable diffs Mar 4, 2025
@ErwanSimonetti ErwanSimonetti marked this pull request as ready for review March 4, 2025 15:31
@ErwanSimonetti ErwanSimonetti changed the title feat: get_diff function returning human-readable diffs feat(diff): get_diff function returning human-readable diffs Mar 4, 2025
@mergify mergify bot requested a review from a team March 4, 2025 16:47
Greesb
Greesb previously approved these changes Mar 4, 2025
Copy link
Contributor

mergify bot commented Mar 4, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot added queued and removed queued labels Mar 4, 2025
jd
jd previously requested changes Mar 5, 2025
@mergify mergify bot dismissed stale reviews from jd and Greesb March 5, 2025 14:20

Pull request has been modified.

@mergify mergify bot requested a review from a team March 5, 2025 14:22
@mergify mergify bot requested a review from a team March 6, 2025 08:49
@ErwanSimonetti ErwanSimonetti force-pushed the comprehensive-diff branch 2 times, most recently from b3622dc to ade357e Compare March 6, 2025 10:50
@mergify mergify bot requested a review from a team March 6, 2025 12:50
@mergify mergify bot requested a review from a team March 6, 2025 13:33
Copy link

@DouglasBlackwood DouglasBlackwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one detail though

@mergify mergify bot requested a review from a team March 6, 2025 14:06
@mergify mergify bot merged commit e57a2d7 into Mergifyio:main Mar 7, 2025
8 checks passed
@mergify mergify bot added queued and removed queued labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants