feature: Allow show thin border above code block when language visible

[bew]

Is your feature request related to a problem? Please describe.

Hello o/

For a code block, when the language is visible and the code is configured with thin borders, the top border is not actually thin but thick.

Describe the solution you'd like

Show the language and its padding around with same hl group, but after the language I want to have thin border, so something like:

##language##_______________________________

Where # is the language_pad, as 'thick' blocks with same hl as the language, and ______ are the thin border chars.
For best default rendering, I think language_pad's default should be changed to 1 or 2 🤔

This should make the language look a bit like a 'tab' above the code 😉

Describe alternatives you've considered

Disabling the language, but then I loose information...

Additional information

No response

[MeanderingProgrammer]

Open to contributions on this one, handling the various different configurations X setups makes implementing this tricky. Since it's not something I like the end result of I'm probably not going to get around to it.

For best default rendering, I think language_pad's default should be changed to 1 or 2 🤔

This is a rendering plugin so the defaults don't have an objective backing, they are just my preferences, and I prefer no padding.

Notes for anyone interested in implementing this:

• Default behavior should remain unchanged, add feature behind a new border value, maybe something like tab
• Need to handle users that do not have concealing enabled, for these users retain current behavior of inlining the language icon before the language name
• Since the icon & border are now both text values on the same line (the thick border behavior works by only adding an hl_group to the line so no text required) you'll need to create a single extmark with virt_text: { icon, border }
• To handle right aligned icons the virt_text value becomes { left_border, icon, remaining_border }
• To handle indented code blocks the virt_text value becomes { leading_spaces, left_border, icon, remaining_border }

[bew]

Since it's not something I like the end result of I'm probably not going to get around to it.

That's fair, I'll try to implement it ;)
Thanks a lot for the small guide!

add feature behind a new border value, maybe something like tab

I'm not sure that's gonna be enough, because border defaults to thin but is currently applied only for the bottom border when there is a language at the top.
And if we have border=tab, how is the border supposed to look at the bottom? Nothing? thin?
I think this behavior (only apply for bottom) is actually surprising to me, because border on other components always apply for both top & bottom borders.

My take on this (while respecting the current rendering) would be to make border always apply for both top & bottom, and add a separate config option like language_line="tab" which would default to language_line="blank-border" (or something like that).

What do you think ? 🤔

[MeanderingProgrammer]

I'm not sure that's gonna be enough, because border defaults to thin but is currently applied only for the bottom border when there is a language at the top.

Not quite, its almost the opposite. Both borders will be thin in 2 situations.

1. There is no language on the code block:

```
print("Hello, World!")
```

2. There is a language on the code block but the user has language rendering disabled:

require('render-markdown').setup({
    code = { style = 'normal' },
})

```python
print("Hello, World!")
```

I think this behavior (only apply for bottom) is actually surprising to me, because border on other components always apply for both top & bottom borders.

Hopefully the information above explains why the behavior is consistent, but only when possible. Other components just don't have the cases where making the border is impossible.

[MeanderingProgrammer]

And if we have border=tab, how is the border supposed to look at the bottom? Nothing? thin?

Since tab implies a thin border at the top, minus the language section, the bottom border should be thin. Otherwise the user would use thick or none.

[MeanderingProgrammer]

My take on this (while respecting the current rendering) would be to make border always apply for both top & bottom, and add a separate config option like language_line="tab" which would default to language_line="blank-border" (or something like that).

LMK if you still think this needs to be the case, I think border = 'tab' should do.

The mental model is something like follow user configuration, unless it's not possible. The not possible part comes from the language icon needing to be integrated into the top border. The current implementation would not work with a thin top border since the border would overwrite the language icon.

[MeanderingProgrammer]

Tracking in Projects so I can keep issues related to bugs / active work.

Feature Requests (view)