Skip to content

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 17, 2025

What does this PR do?

Fix ignored linting rules. All rules were not violated except for RET504 (violations autofixed).

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21229.org.readthedocs.build/en/21229/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Sep 17, 2025
@matsumotosan matsumotosan changed the title tests/ linting Remove unviolated linting rules Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (e088694) to head (b4b8a3f).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #21229    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         269      269            
  Lines       23688    23688            
========================================
- Hits        20669    20533   -136     
- Misses       3019     3155   +136     

Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer keeping explicit assignments for readability/debugging, but I’m fine with enabling RET504 if consistency is the goal.

@Borda
Copy link
Member

Borda commented Sep 18, 2025

I personally prefer keeping explicit assignments for readability/debugging, but I’m fine with enabling RET504 if consistency is the goal.

You can simply add a comment which would be even better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants