-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove unviolated linting rules #21229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21229 +/- ##
========================================
- Coverage 87% 87% -1%
========================================
Files 269 269
Lines 23688 23688
========================================
- Hits 20669 20533 -136
- Misses 3019 3155 +136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer keeping explicit assignments for readability/debugging, but I’m fine with enabling RET504
if consistency is the goal.
You can simply add a comment which would be even better |
What does this PR do?
Fix ignored linting rules. All rules were not violated except for RET504 (violations autofixed).
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21229.org.readthedocs.build/en/21229/