Skip to content

Bugfix/nested array #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bugfix/nested array #444

wants to merge 6 commits into from

Conversation

ccamarat
Copy link

@ccamarat ccamarat commented Apr 9, 2018

Addresses #428.

@coveralls
Copy link

Coverage Status

Coverage decreased (-18.05%) to 79.586% when pulling 4d480d5 on ccamarat:bugfix/nested-array into e8540dc on Leonidas-from-XIV:master.

@ccamarat
Copy link
Author

ccamarat commented Apr 9, 2018

Hmmm. Apparently I got bit by the "Works on my machine" bug. I'm not sure I can explain how these changes would work on Node 6 and 9 but not 4 and 8; any ideas?

@Leonidas-from-XIV
Copy link
Owner

Maybe because the test is unstable so it breaks in 50% of cases. I haven't looked at the code yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccamarat @coveralls @Leonidas-from-XIV @chriscamaratta-dp