Load dataframe-jupyter from core in notebooks #1415
Conversation
… in notebooks. Requires Kotlin/kotlin-jupyter#488
|
Kotlin/kotlin-jupyter#488 was merged, however, there's still the issue of providing "unsupported keys" in |
| "descriptors": [ | ||
| { | ||
| "init": [ | ||
| "@Suppress(\"INVISIBLE_MEMBER\", \"INVISIBLE_REFERENCE\") USE { dependencies(\"org.jetbrains.kotlinx:dataframe-jupyter:${org.jetbrains.kotlinx.dataframe.BuildConfig.VERSION}\") }" |
There was a problem hiding this comment.
Maybe make it public or semi-hidden through some hacks? This suppress warning can break in future versions of kotlin
There was a problem hiding this comment.
it's internal, so basically semi-hidden, right?
There was a problem hiding this comment.
In my opinion we could also add it to a companion object of DataFrame, like DataFrame.VERSION; doesn't even need to be hidden
There was a problem hiding this comment.
semi hidden but also avoid suppressing invisible reference :)
DataFrame.VERSION idk, not worth to pollute IO scope with it
There was a problem hiding this comment.
I might not need it after all :) Currently, the tests in dataframe-jupyter are failing because the libraries.json is in the classpath. I'm trying to generate and include it on the fly upon publishing only
|
wow that's a lot of failing tests all of a sudden, let me check.. ...of course... the tests are trying to load the META-INF file from :core using a VERSION that doesn't exist. This file should be ignored by the tests |
|
Okay, I removed the libraries.json file from the resources. Now it's only added upon publishing, similar to running KoDEx only upon publishing. That way the tests that depend on :core don't have to deal with the file and potentially try to load a version of dataframe-jupyter that doesn't exit. |
|
"upon publishing" is not a good idea. It's still triggered from some integration tests that call Instead, I added a new gradle parameter I ran a test-run of publish-dev and it seems to both build/test fine and publish with the json file included: |
Fixes #1140
Adds libraries.json which loads dataframe-jupyter from dataframe-core in notebooks. Requires Kotlin/kotlin-jupyter#488.
TODO: Wait for the above PR to be merged and published. Adding this new argument will break existing kernels due to the
"descriptors"argument being unknown.