fix(entities-plugins): freeform - default card appearance for record array #2473
+81
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2eha0
force-pushed
the
fix/objectfield
branch
from
eae673e to
e17fd1e
Compare
2eha0
changed the title
2eha0
commented
Sep 10, 2025
| v-bind="props" | ||
| appearance="card" | ||
| /> | ||
| </FieldRenderer> |
There was a problem hiding this comment.
No longer need overriding for record array
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
2eha0
commented
Sep 10, 2025
| @@ -44,15 +32,11 @@ | |||
| <CalloutsForm /> | |||
|
|
|||
| <ObjectField | |||
| appearance="card" | |||
There was a problem hiding this comment.
The appearance is not working before, once I fixed it, it seems a bit weird, so let's remove it
Justineo
reviewed
Sep 11, 2025
| @@ -164,6 +166,10 @@ const realResetLabelPath = computed(() => { | |||
|
|
|||
| const fieldAttrs = useFieldAttrs(field.path!, toRef(() => ({ required, ...props, resetLabelPath: realResetLabelPath.value }))) | |||
| const realAdded = computed(() => !fieldAttrs.value.required ? added.value ?? defaultAdded : true) | |||
| const wrapper = computed(() => { | |||
| if (appearance === 'card') return 'KCard' | |||
There was a problem hiding this comment.
Suggested change
| if (appearance === 'card') return 'KCard' | |
| if (appearance === 'card') return KCard |
And we should explicitly import components we are using here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR:
appearanceprop ofObjectFieldBefore
After