Skip to content

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Sep 3, 2025

Summary

Add expand/collapse support to sidenav groups for KHCP-17790.

@kaiarrowood kaiarrowood self-assigned this Sep 3, 2025
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is still a draft, but wanted to provide some feedback early

@kaiarrowood kaiarrowood marked this pull request as ready for review September 5, 2025 13:14
@kaiarrowood kaiarrowood requested review from jillztom and a team as code owners September 5, 2025 13:14
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

With the flag enabled, the spacing here (red area) increases more than it should. Can you compare with the flag off and adjust?

I believe the code looks good based on my previous review and our discussion but I'll take another look shortly on the code review

@adamdehaven
Copy link
Member

image image

Can you update the focus state (keyboard nav) of the collapse triggers to more closely match the item focus-visible state? I believe we're using some navigation design tokens if you look at the current implementation for the sidebar items

@adamdehaven
Copy link
Member

question: when users expand/collapse items manually, and then navigate to another MFE app, the collapse state will be reset. Are we planning to keep this consistent via logic in the App Shell?

@adamdehaven
Copy link
Member

adamdehaven commented Sep 5, 2025

image

For the menu on mobile, would it make sense to automatically expand all items at smaller viewports? (I can show you a way to do this via JS if needed)

@kaiarrowood kaiarrowood requested review from kongponents-bot and a team as code owners September 8, 2025 14:36
@kaiarrowood kaiarrowood merged commit c916bcf into main Sep 15, 2025
9 checks passed
@kaiarrowood kaiarrowood deleted the feat/khcp-17790-sidenav-collapse branch September 15, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants