fix(translator): check gateway class and do not skip listeners when gateway class is not managed by KIC #7666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot managed by KIC
randmonkey
force-pushed
the
fix/do_not_skip_gateway_listener_certs
branch
from
9016641 to
915a344
Compare
randmonkey
commented
Aug 4, 2025
| // Check if listener is marked as programmed when the gateway is controlled by KIC in its spec and has the "Unmanaged" annotation. | ||
| // If the GatewayClass is does not satify the condition, the gateway is considered to be managed by other components (for example Kong Oprator), | ||
| // So we do not check the "Programmed" condition before extracting the certificate from the listener. | ||
| if gwc.Spec.ControllerName == gatewayapi.GatewayController(t.gatewayControllerName) && |
There was a problem hiding this comment.
REVIEW: should we check controller name here or just check the unmanaged annotation?
randmonkey
commented
Aug 4, 2025
| @@ -440,6 +441,11 @@ func (r *GatewayReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct | |||
| debug(log, gateway, "Ensured gateway was removed from the data-plane (if ever present)") | |||
| return ctrl.Result{}, nil | |||
| } | |||
| err := r.DataplaneClient.UpdateObject(gwc) | |||
There was a problem hiding this comment.
REVIEW: Should we store the gatewayclass into translator cache here or in the gateway class controller?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
=====================================
Coverage 77.2% 77.3%
=====================================
Files 222 222
Lines 25870 25900 +30
=====================================
+ Hits 19994 20022 +28
- Misses 4849 4852 +3
+ Partials 1027 1026 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do not skip checking certificates in gateway listeners that does not has "Programmed" condition if the
GatewayClassis not managed by KIC. The change fixes an issue when KIC is deployed by gateway operator, certificates gets deleted when dataplane (Kong gateway) pods are changed.Which issue this PR fixes:
fixes #7660 (then also Kong/kong-operator#1769)
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR