chore: fix kubernetes-configuration CRD installation in integration tests #7659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
fix-crd-installation-in-integration-tests
branch
2 times, most recently
from
503bd8a to
0237118
Compare
pmalek
force-pushed
the
fix-crd-installation-in-integration-tests
branch
from
0237118 to
2d8fb9d
Compare
randmonkey
approved these changes
Aug 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7659 +/- ##
=======================================
- Coverage 77.2% 77.1% -0.1%
=======================================
Files 222 222
Lines 25871 25870 -1
=======================================
- Hits 19986 19969 -17
- Misses 4865 4877 +12
- Partials 1020 1024 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pmalek
added a commit
that referenced
this pull request
Aug 1, 2025
…ests (#7659) (#7663) (cherry picked from commit 5eea70b) Co-authored-by: Patryk Małek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
>= 2was making the code to split the alpha/beta/rc versions (returning empty string fromDependencyModuleVersionGitwhich when passed tokustomizegets the latest version of provided module) where in reality this was only meant to do so for Go mod pseudo versions.Which issue this PR fixes:
Special notes for your reviewer:
Additionally now the version of a module from which the CRDs are being installed is printed in the logs:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR