-
Notifications
You must be signed in to change notification settings - Fork 607
fix(konnect): Use correct label value of secret to store license #7648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2017c1
to
7a02928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd add a test for that but I can see that this can be non insignificant effort to simulate failures to connect to Konnect in envtest
or integration test.
Perhaps we add an issue for that? Not sure when we'd prioritize that though 🤔
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7648 +/- ##
=======================================
- Coverage 77.4% 77.3% -0.1%
=======================================
Files 222 222
Lines 25869 25870 +1
=======================================
- Hits 20039 20020 -19
- Misses 4807 4830 +23
+ Partials 1023 1020 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think we could check if the secret is created/updated in the current integration tests as the first step. I would create an issue for a test that simulate Konnect failures as it takes a significant effort. |
Co-authored-by: Patryk Małek <[email protected]>
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/16611875343 |
8b32e4d
to
704a6a5
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/16613741821 |
* fix label value of secret to store license * Update internal/labels/labels.go Co-authored-by: Patryk Małek <[email protected]> * check secret for stored license --------- Co-authored-by: Patryk Małek <[email protected]> (cherry picked from commit e37c1cd)
…) (#7651) * fix label value of secret to store license * Update internal/labels/labels.go * check secret for stored license --------- (cherry picked from commit e37c1cd) Co-authored-by: Tao Yi <[email protected]> Co-authored-by: Patryk Małek <[email protected]>
What this PR does / why we need it:
The
Secret
to store Konnect licenses was using an invalid label value causing that theSecret
cannot be created/updated.Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR