Skip to content

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jul 29, 2025

What this PR does / why we need it:

The Secret to store Konnect licenses was using an invalid label value causing that the Secret cannot be created/updated.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey force-pushed the fix/store_license_label branch from b2017c1 to 7a02928 Compare July 29, 2025 12:52
pmalek
pmalek previously approved these changes Jul 29, 2025
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd add a test for that but I can see that this can be non insignificant effort to simulate failures to connect to Konnect in envtest or integration test.

Perhaps we add an issue for that? Not sure when we'd prioritize that though 🤔

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.3%. Comparing base (a278f8c) to head (704a6a5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/konnect/license/client.go 0.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #7648     +/-   ##
=======================================
- Coverage   77.4%   77.3%   -0.1%     
=======================================
  Files        222     222             
  Lines      25869   25870      +1     
=======================================
- Hits       20039   20020     -19     
- Misses      4807    4830     +23     
+ Partials    1023    1020      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@randmonkey
Copy link
Contributor Author

Ideally we'd add a test for that but I can see that this can be non insignificant effort to simulate failures to connect to Konnect in envtest or integration test.

Perhaps we add an issue for that? Not sure when we'd prioritize that though 🤔

I think we could check if the secret is created/updated in the current integration tests as the first step. I would create an issue for a test that simulate Konnect failures as it takes a significant effort.

@randmonkey randmonkey added the ci/run-e2e Trigger e2e test run from PR label Jul 30, 2025
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/16611875343

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 30, 2025
@randmonkey randmonkey force-pushed the fix/store_license_label branch from 8b32e4d to 704a6a5 Compare July 30, 2025 03:01
@randmonkey randmonkey added the ci/run-e2e Trigger e2e test run from PR label Jul 30, 2025
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/16613741821

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 30, 2025
@randmonkey randmonkey requested a review from pmalek July 30, 2025 06:42
@randmonkey randmonkey added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit e37c1cd Jul 30, 2025
177 of 178 checks passed
@randmonkey randmonkey deleted the fix/store_license_label branch July 30, 2025 08:38
team-k8s-bot pushed a commit that referenced this pull request Jul 30, 2025
* fix label value of secret to store license

* Update internal/labels/labels.go

Co-authored-by: Patryk Małek <[email protected]>

* check secret for stored license

---------

Co-authored-by: Patryk Małek <[email protected]>
(cherry picked from commit e37c1cd)
randmonkey added a commit that referenced this pull request Jul 30, 2025
…) (#7651)

* fix label value of secret to store license

* Update internal/labels/labels.go



* check secret for stored license

---------


(cherry picked from commit e37c1cd)

Co-authored-by: Tao Yi <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants