Fixed CSS for publisher flipper #3461
Conversation
|
Just to let you know, I'm still planning to merge this in. Just not yet ready to do the testing to see if the width issue will be impactful. |
|
@MrRobotjs since you like CSS, could you look into this PR and see if you can remove the one constraint that's holding me from merging in (aka the width issue)? |
|
I tested this and images that have a longer width are still square. I think the proper fix would be to do what @therobbiedavis proposed here #3451 (comment) , i was already implementing this but I tried the idea of only showing the text and on hover a tooltip with the image will appear above instead. But I can also just make it so only the image appears if available or text if no image is available. |
- Adjusted for dynamic publish width, but fixed height - Adjusted divs for max-content - Fixed flipper positioning
|
@heyhippari @MrRobotjs @majora2007 I have fixed this up according to the comments. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CSS styling issues for the publisher flipper component by updating the layout, positioning, and sizing properties. The changes enable the publisher flipper to properly display with correct dimensions and positioning.
Key Changes
- Replaced static publisher display with an active publisher flipper component
- Modified CSS to use content-based width instead of fixed width
- Updated image dimensions and positioning properties for better visual alignment
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| metadata-detail-row.component.html | Uncommented publisher flipper component and commented out static publisher display |
| publisher-flipper.component.scss | Updated width calculation, positioning, and transform properties for proper flipper animation |
| publisher-flipper.component.html | Changed image dimensions from fixed 32px to auto width with 24px height |
UI/Web/src/app/_single-module/publisher-flipper/publisher-flipper.component.scss
Outdated
Show resolved
Hide resolved
UI/Web/src/app/_single-module/publisher-flipper/publisher-flipper.component.scss
Show resolved
Hide resolved
|
Visually, it looks good now. But there seems to be a bug in the flipper code, I only ever see it flipping through 2 or 3 publishers. I have 5 assigned now, but I can only see the first two, sometimes it seems to switch which publishers it flips through, but I don't know when 2025-07-26.17-41-09.mp4 |
|
Looks like there may be some leftover logic for me to handle. I can take care of the rest of this. |
Fixed
As mentioned on Discord, one caveat is that the width will be based upon the first publisher.