Skip to content

Conversation

bjarthur
Copy link
Contributor

fixes #11

@coveralls
Copy link

coveralls commented Mar 15, 2020

Coverage Status

Coverage decreased (-93.3%) to 6.742% when pulling e878199 on bjarthur:bja/compat into e293b7b on JuliaNLSolvers:master.

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #12 into master will decrease coverage by 92.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #12       +/-   ##
==========================================
- Coverage     100%   7.77%   -92.23%     
==========================================
  Files           2       3        +1     
  Lines           6      90       +84     
==========================================
+ Hits            6       7        +1     
- Misses          0      83       +83
Impacted Files Coverage Δ
src/types.jl 3.84% <ø> (-96.16%) ⬇️
src/OptimBase.jl 100% <ø> (ø)
src/api.jl 7.93% <0%> (-92.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e293b7b...e878199. Read the comment docs.

@bjarthur
Copy link
Contributor Author

this is ready i think. comments?

@martinholters
Copy link

I'm also a bit hampered by #11 and would appreciate it if this could merged and a new release tagged soonish.

@Vaibhavdixit02
Copy link

Bump @pkofod

@ChrisRackauckas
Copy link
Contributor

and add CompatHelper please.

@pkofod pkofod merged commit 4c0fcd2 into JuliaNLSolvers:master Mar 25, 2020
@bjarthur bjarthur deleted the bja/compat branch March 25, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Compat requirements
6 participants