-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
try @allocated
changes on 1.12
#59532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.12
Are you sure you want to change the base?
Conversation
1fad908
to
084dab1
Compare
@nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed3 packages crashed only on the current version.
51 packages crashed on the previous version too. ✖ Packages that failed100 packages failed only on the current version.
3610 packages failed on the previous version too. ✔ Packages that passed tests44 packages passed tests only on the current version.
5773 packages passed tests on the previous version too. ➖ Packages that were skipped altogether1358 packages were skipped on the previous version too. |
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed4 packages crashed only on the current version.
49 packages crashed on the previous version too. ✖ Packages that failed36 packages failed only on the current version.
3589 packages failed on the previous version too. ✔ Packages that passed tests50 packages passed tests only on the current version.
5860 packages passed tests on the previous version too. ➖ Packages that were skipped altogether1359 packages were skipped on the previous version too. |
@nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. Report summary✖ Packages that failed1 packages failed only on the current version.
2 packages failed on the previous version too. ✔ Packages that passed tests1 packages passed tests only on the current version.
29 packages passed tests on the previous version too. |
Looks pretty good? Merge @JeffBezanson? |
We shouldn’t merge to 1.12 before master |
This is to see how this change affects 1.12 PkgEval. Note we do not expect 100% compatibility for this, because number of allocations is implementation-dependent and not part of the API. Here I want to (1) restore the scope behavior for complex expressions, (2) try to avoid spurious allocations from call sites, and (3) failing that, make the behavior more predictable so tests can be updated more easily if they break.
@nanosoldier
runtests(ALL, vs = ":release-1.12")