LibGit2: Update to new NetworkOptions ca_root_locations API #58819
+38
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update LibGit2 to use the new NetworkOptions.ca_root_locations() API which returns a tuple of (files, directories) instead of a single path. Key improvements: - Query SSL backend first using git_libgit2_feature_backend - Only call NetworkOptions.ca_root_locations() for backends that support custom certificates (OpenSSL and mbedTLS) - Skip certificate configuration for system backends (SecureTransport, Schannel, WinHTTP) which use system certificates - Support multiple certificate directories for OpenSSL by joining with delimiter - Warn when multiple directories specified for mbedTLS (only supports one) - Warn when multiple certificate files specified (only first is used) This avoids unnecessary work for system certificate backends and properly handles SSL_CERT_FILE and SSL_CERT_DIR environment variables based on the underlying SSL/TLS implementation.
|
(Do not merge until the NetorkOptions PR is merged and bumped here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts LibGit2 to the new
ca_root_locationsAPI proposed in JuliaLang/NetworkOptions.jl#42. Opening this up early to have both sides up together. Obviously it's a little messy to have an API in NetworkOptions that returns multiples files/directories when this isn't necessarily supported in downstream clients. However, I think it's important that the case where SSL_CERT_DIR is delimiter separated and libgit2 is using openssl as its backend works, since we might encounter configurations that that look like that. As I said in the NetworkOptions PR, I could imagine situations in which having multiple files/directories could be useful (e.g. to always push our bundled files), but since we don't have an immediate use case for it, I don't see any great need to tweak our upstream libraries to support it. That said, I still think it's worth having NetworkOptions have the full API so that we don't have to break the API again in the future if we ever want to do this.Largely written by Claude.