avoid creating a new Face in get calls when FACES has that face available
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/face_get
branch
from
f4cddb6 to
25af451
Compare
Instead of providing Face() as the fallback value with a get call, we can instead provide the constructor Face as the first argument, preventing it from being called needlessly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get(f::Function, collection, key)method is typically better thanget(collection, key, f())whenfis not trivial. This avoids calling it unless it is actually needed.Made on top of #75 to avoid a merge conflict.
Before (same benchmark as in #75):
After