do not import methods that are not extended and use explicit module prefix for methods that are imported
#69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me this feels like a neutral change, I'm actually more worried about forgetting to add a method than accidental extension (if we go through with eliminating the type piracy, I suspect this will become moot as all of this will live in |
Avoid importing bindings that are not extended, and use explicit module prefixes for those that we do extend. This make it clearer when and where overloads are occurring.
tecosaur
force-pushed
the
kc/import_uing
branch
from
faabf4e to
58507e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids accidentally extending methods and makes it more clear what methods are doing overloads