Introduce specialised write for AnnotatedIOBuffer #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JuliaLang/julia@f117a500ca93, the AnnotatedIOBuffer type was introduced. If you write from an AnnotatedIOBuffer to another kind of IO, currently all styling information is lost. This seems undesirable, and we can make it work more like writing an AnnotatedString to IO ... by converting this to an AnnotatedString write within a specialised write method. The conversion surely adds overhead, but it's a very staightforward way to make this work. If this ends up being a legitimate performance concern, we can always revisit this and either: - Add a specialised code path for AnnotatedIOBuffer - Try to make the current AnnotatedString-oriented methods more generic (somehow)
tecosaur
force-pushed
the
annotatediobuffer-specialisation
branch
from
3c16ae5 to
11c5bd9
Compare
|
Since this has already been requested, is fairly straightforward, and now has tests, I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JuliaLang/julia@f117a500ca93, the AnnotatedIOBuffer type was introduced. If you write from an AnnotatedIOBuffer to another kind of IO, currently all styling information is lost.
This seems undesirable, and we can make it work more like writing an AnnotatedString to IO ... by converting this to an AnnotatedString write within a specialised write method.
The conversion surely adds overhead, but it's a very staightforward way to make this work. If this ends up being a legitimate performance concern, we can always revisit this and either:
generic (somehow)
The utility of this was first expressed in JuliaLang/julia#51928 (comment)
cc: @vtjnash