Fix windows library filename #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The name was accidentally changed to sys.dll in a previous refactor * Also rename `get_sysimg_file` -> `get_library_filename`. It used to be used to get the sysimg filename for `create_app` and `create_lib`, but now it's only used by `create_lib`.
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 2 2
Lines 464 464
=======================================
Hits 442 442
Misses 22 22
Continue to review full report at Codecov.
|
|
Thanks! |
|
I just wanted to ask when the next verison release is planned? We have a PackageCompiler-Dependency in one of our libs and it's currently not working with the old/wrong DLL-naming. Best regards! |
|
Going to make a release now. |
|
Thank you very much! |
|
Okay, it took me a day, but v2.0.5 is released now. |
|
Thank you very much @kmsquire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys.dllin a previous refactorget_sysimg_file->get_library_filename. It used tobe used to get the sysimg filename for
create_appandcreate_lib,but now it's only used by
create_lib.Fixes #653