backport to v1: _register_kinds!: prevent unintentional closure capture, boxing
#589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to eliminate the exact same invalidations as PR #588. |
…liaLang#586) The variable `i` was unintentionally shared between the generator closure in `_register_kinds!` and another part of the body of `_register_kinds!`. Thus `i` was boxed, causing trouble for inference. Fix this by moving the part of `_register_kinds!` with `i` to a new function. Fixing this should make the sysimage more resistant to invalidation, once the change propagates to Julia itself. (cherry picked from commit 00bd17e)
nsajko
force-pushed
the
backport_pr_586
branch
from
d60c06f to
ed52e98
Compare
|
bump |
1 similar comment
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
iwas unintentionally shared between the generator closure in_register_kinds!and another part of the body of_register_kinds!. Thusiwas boxed, causing trouble for inference.Fix this by moving the part of
_register_kinds!withito a new function.Fixing this should make the sysimage more resistant to invalidation, once the change propagates to Julia itself.
xref:
the PR being backported:
_register_kinds!: prevent unintentional closure capture, boxing #586backport release PR Backports release 1 #577