Skip to content

Conversation

simeonschaub
Copy link
Member

companion to JuliaLang/julia#56153

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream reception of this seems overall negative, so I guess we might not do it?

A minor comment if we do ever merge this - for tests we should never depend on VERSION unless really necessary: JuliaSyntax is multi-version aware :)

Comment on lines +192 to +206
if VERSION >= v"1.12-"
@test parsestmt("for x=xs\ny\nelse\nz\nend") ==
Expr(:for,
Expr(:(=), :x, :xs),
Expr(:block,
LineNumberNode(2),
:y,
),
Expr(:block,
LineNumberNode(4),
:z,
LineNumberNode(5)
)
)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if VERSION >= v"1.12-"
@test parsestmt("for x=xs\ny\nelse\nz\nend") ==
Expr(:for,
Expr(:(=), :x, :xs),
Expr(:block,
LineNumberNode(2),
:y,
),
Expr(:block,
LineNumberNode(4),
:z,
LineNumberNode(5)
)
)
end
@test parsestmt("for x=xs\ny\nelse\nz\nend", version=v"1.12") ==
Expr(:for,
Expr(:(=), :x, :xs),
Expr(:block,
LineNumberNode(2),
:y,
),
Expr(:block,
LineNumberNode(4),
:z,
LineNumberNode(5)
)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants