Jupyter messaging updates/correctness #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Necessary for any future `"update_display_data"` message implementation)
halleysfifthinc
force-pushed
the
messaging-updates
branch
from
236b63e to
bcf8553
Compare
|
Bump |
JamesWrigley
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Not strictly necessary for this PR, but we should start using jupyter_kernel_test in the tests: https://github.com/jupyter/jupyter_kernel_test
halleysfifthinc
force-pushed
the
messaging-updates
branch
from
8b56a0c to
f63ccfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 10.51% 10.48% -0.03%
==========================================
Files 14 14
Lines 818 820 +2
==========================================
Hits 86 86
- Misses 732 734 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgversionin"kernel_info_request"to report the IJulia version"kernel_info_request"sent on both the shell/requests channel AND the control channel. (The latter is not described as possible according to the docs.){ 'status': 'ok' }transientmetadata field was added in protocol version 5.1. Without the ability to add transient metadata,"update_display_data"messages can't be used to update/redisplay existing outputs (while participating in/with the rest of the IJulia display machinery). Related PR Function to publish raw/encoded display data #946 is more extensive and stalled; this is the minimum necessary change to support this.Fixes #953
Fixes #1000
Reference: https://jupyter-client.readthedocs.io/en/latest/messaging.html