Iterators.cycle(iter, n)
#819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martin Holters <[email protected]>
mcabbott
commented
Feb 13, 2024
mcabbott
commented
Feb 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 92.35% 92.37% +0.02%
==========================================
Files 2 2
Lines 340 341 +1
==========================================
+ Hits 314 315 +1
Misses 26 26 ☔ View full report in Codecov by Sentry. |
mcabbott
commented
Feb 14, 2024
README.md
Outdated
|
|
||
| ## Supported features | ||
|
|
||
| * `Iterators.cycle(itr, n)` is the lazy version of `repeat(vector, n)`. ([#47354]) (since Compat 4.12.0) |
There was a problem hiding this comment.
Suggested change
| * `Iterators.cycle(itr, n)` is the lazy version of `repeat(vector, n)`. ([#47354]) (since Compat 4.12.0) | |
| * `Iterators.cycle(itr, n)` is the lazy version of `repeat(vector, n)`. ([#47354]) (since Compat 4.13.0) |
Wrong number!
Perhaps this and #818 can be one release.
There was a problem hiding this comment.
BTW I don't have merge rights here. This may need a rebase after #818 is in, before tagging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#47354