[JVM] Emit lookupswitch/tableswitch for Short/Byte if possible #5464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaventz
force-pushed
the
KT-76589-when-opimization-6-12
branch
from
d582c71 to
7c1ab7b
Compare
scaventz
requested review from
mMaxy,
abelkov,
agamzikova,
ermolenkodev,
grechkovlad,
kunyavskiy and
JSMonk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix KT-76589.
This PR enables generation of
TABLESWITCH/LOOKUPSWITCHfor when-expressions overShort/Byte, but does not support emitting those bytecodes for when-expression overs mixed types.The idea of generating a
lookupswitchfor the test caselookupSwitchOverMixTypes.ktwould require a bit more work if it is possible and worthwhile.Test data files
bytecodeText\when\tableSwitch.ktandbytecodeText\when\lookupSwitch.ktare removed in this PR, and the test cases in them are separated into different test files.