This PR refactors test_pools.py to align with the new build Method #3124
+145
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoura
requested changes
Sep 4, 2025
mkoura
requested changes
Sep 5, 2025
| src_address=src_address, | ||
| tx_name=f"{temp_template}_reg_deleg", | ||
| tx_files=tx_files, | ||
| witness_count_add=len(tx_files.signing_key_files), |
There was a problem hiding this comment.
You are building, but not signing and submitting the tx.
mkoura
requested changes
Sep 11, 2025
mkoura
requested changes
Sep 15, 2025
| @@ -144,8 +146,7 @@ def _register_stake_pool_w_build( | |||
| reward_account_vkey_file: A path to reward account vkey file (optional). | |||
| deposit: A deposit amount needed by the transaction (optional). | |||
| destination_dir: A path to directory for storing artifacts (optional). | |||
|
|
|||
| Returns: | |||
| Returns: | |||
There was a problem hiding this comment.
The docstrings are supposed to follow one of the standard formats. We are using the google style format of docstrings. Please leave the Returns formatting as it was: blank line above, no blank line below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces explicit support for the
transaction build-estimatecommand in stake pool creation, registration, delegation, and deregistration flows. It also replaces the legacyuse_build_cmdflag with the more flexiblebuild_methodparameter across stake pool utilities and tests.Key Changes
Utilities
_register_stake_pool_w_build_estand_create_stake_pool_w_build_esthelper functions to handle stake pool registration usingbuild-estimate._create_register_pool,_create_register_pool_delegate_stake_tx, and_create_register_pool_tx_delegate_stake_txto branch onbuild_method(BUILD,BUILD_RAW,BUILD_EST) instead ofuse_build_cmd.Tests
TestStakePool) to usebuild_method.test_stake_pool_metadata,test_create_stake_pool,test_deregister_stake_pool,test_update_stake_pool_metadata,test_update_stake_pool_parameters,test_pool_deregistration_not_registered) to supportBUILD_EST.Test Run: https://github.com/IntersectMBO/cardano-node-tests/actions/runs/17446898448/job/49543468841
Test Run: https://github.com/IntersectMBO/cardano-node-tests/actions/runs/17478711486/job/49644613878