Skip to content

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Aug 14, 2025

Changelog

- description: |
   Allowed script address to be used for stake pool reward account when constructing registration certificate.    

# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

This is supported by the protocol, there's no reason not to support it in the CLI. This leads to a breaking change in the command-line options, which I deem acceptable to preserve some coherence between the options. Feel free to disagree and change option names for your liking.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

It's mostly re-using existing code and piggybacking on what's already done for the creation of stake address. It type-checks so it probably works 🤓. I made a single manual test with a dummy native script.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@KtorZ
Copy link
Contributor Author

KtorZ commented Aug 14, 2025

FML. I've used main as a base branch.

@@ -39,8 +41,8 @@ hprop_golden_shelley_stake_pool_registration_certificate = propertyOnce . H.modu
, operatorVerificationKeyFile
, "--vrf-verification-key-file"
, vrfVerificationKeyFile
, "--reward-account-verification-key-file"
, ownerVerificationKeyFile
, "--pool-reward-account-stake-verification-key-file"
Copy link
Contributor

@Jimbo4350 Jimbo4350 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maintain backwards compatibility here and add a deprecation warning in the help text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants