-
Notifications
You must be signed in to change notification settings - Fork 16
Closing #141 - var
guidance
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dac4fb6
Add var guidance to xml
joeriddles 1bbc71c
Remove global.json
joeriddles ac94771
Ignore vs vode .devcontainer
joeriddles 8b23d6a
Merge branch 'main' of https://github.com/IntelliTect/CodingGuideline…
joeriddles 164f446
Move XMLtoMD project
joeriddles 4d790f8
Change Guideline to record from class
joeriddles a28563c
Add GuidelineXmlToMD mstest project
joeriddles a375482
Implement GuidelineXmlFileReader test
joeriddles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
Keboo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
"sdk": { | ||
"version": "3.1.407" | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a key,
XMLtoMD.GuidelineXmlToMD.Guidelines.GetHashCode
throws an error because it expects itsKey
property to be non-null. @Keboo what do you think is a better solution: refactorGetHashCode
onGuideline.cs
or add keys to these new XML lines?See:
CodingGuidelines/XMLtoMD/GuidelineXmlToMD/Guideline.cs
Line 20 in d5795c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O that is not good. I missed that previously. I would expect the Guidline to use all of its members to determine equality/hashcodes.
An even better solution would be to just make it a record type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will investigate switching to a record type. I haven't been working with C# lately, so I have some reading up to do on how record types work. Fortunately, I know some people that did a meetup on the topic. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public record Guideline(string Text, string Severity, string Section, string Subsection, string? Key IList<string>? Comments);
should probably do it