Bug fix wifi scan #155
Merged
Bug fix wifi scan #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
After all, the lack of complete reset of the hardware transceiver and its fw stack deinit seem not be the actual issue.
However, being aware of it, allowed me to start from a clean and fresh hardware setup and reproduceable behaviors during the debugging 😃
The issue
Calling
cy_wcm_stop_scan()was the primary issue making the program to hang. Calling that function inside the callback is generating some race condition.As anyhow we want to stop the scan unconditionally (weather it is completed or due to timeout), we just stop after the blocking scan completion wait.
Additional fix/improvements
scanNetworks()calls would overflow the array positions and/or provide previous scan results.Beside the actions in this PR, these workflows already perform the scan before the rest of the station tests: