Skip to content

Conversation

ShubyM
Copy link
Collaborator

@ShubyM ShubyM commented Aug 1, 2025

Attempts to implement #448 by truncating the tool call output. If anyone has suggestions or better ideas feel free to let me know!

Before:
image

After:
image

@ShubyM ShubyM changed the title [WIP] feat: show tool call output in terminal ui feat: show tool call output in terminal ui Aug 5, 2025
@ShubyM ShubyM marked this pull request as ready for review August 6, 2025 18:06
Copy link
Member

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should add a flag to opt-in to display output (without truncation).

@droot
Copy link
Member

droot commented Aug 7, 2025

@ShubyM The change is looking good.

While you are at it, can we also fix the alignment for tool request/response. Mainly following changes:

  1. Running: <tool> should have a new line before it (no line spacing looks strange)
  2. Tool output is not aligned with anything

I think if you render these through markdown you will get the line spacing and left/right spaceing automatically. We used to have that and I think it got lost during the refactoring.

@ShubyM
Copy link
Collaborator Author

ShubyM commented Aug 7, 2025

With markdown rendering on the tool call response we get an output that looks like this:

image

I'm not sure if there is an easy way to fix the table alignment when using the markdown rendering

@droot
Copy link
Member

droot commented Aug 8, 2025

With markdown rendering on the tool call response we get an output that looks like this:

image I'm not sure if there is an easy way to fix the table alignment when using the markdown rendering

This is an improvement over what we have, so merging it in. We might tweak the truncation limit to something lower.

@droot droot merged commit 3b32d8f into main Aug 8, 2025
6 checks passed
@ShubyM ShubyM deleted the feat/toolcall-output-terminal branch August 11, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants