feat: modularize prompt resolution with new promptFile
#395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droot
requested changes
Jul 8, 2025
k8s-bench/main.go
Outdated
|
|
||
| // ResolvePrompt resolves the prompt from either inline or file source | ||
| func (s *ScriptStep) ResolvePrompt(baseDir string) (string, error) { | ||
| // If both are provided, promptFile takes precedence |
There was a problem hiding this comment.
I think we should simply fail when both are provided to avoid any confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to store task prompts in external files instead of embedding them directly in YAML configurations.
Key Changes
PromptFilefield toScriptStepstructResolvePrompt()method to load prompts from files or inline contentsetup-dev-clustertask to use externalsetup-dev-cluster.mdfileBenefits