Skip to content

Conversation

prasad89
Copy link
Contributor

@prasad89 prasad89 commented Jun 18, 2025

This PR introduces a new evaluation task to test the assistant’s ability to diagnose and resolve pods crashing due to OOMKilled errors.

@prasad89
Copy link
Contributor Author

/cc @droot @noahlwest

Copy link
Collaborator

@noahlwest noahlwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just 1 comment here, the rest looks good to me.

@prasad89 prasad89 requested a review from noahlwest June 18, 2025 17:53
Copy link
Member

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the eval. This is a good one.

@prasad89 prasad89 requested a review from droot June 18, 2025 20:00
@droot
Copy link
Member

droot commented Jun 18, 2025

Once @noahlwest approves, we can get this in.

@droot
Copy link
Member

droot commented Jun 19, 2025

Once @noahlwest approves, we can get this in.

I see @noahlwest comment's are addressed, so will get this in.

@droot droot merged commit d541935 into GoogleCloudPlatform:main Jun 19, 2025
6 checks passed
@prasad89 prasad89 deleted the fix-oomkilled branch June 28, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants