Skip to content

various improvements #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2025
Merged

various improvements #2143

merged 1 commit into from
Aug 30, 2025

Conversation

Byron
Copy link
Member

@Byron Byron commented Aug 29, 2025 •
edited
Loading

Tasks

  • fix CI

@Byron
Copy link
Member Author

Byron commented Aug 29, 2025

The issue doesn't reproduce locally, but the problem is that an untrusted path ends up trusted.
Locally it doesn't reproduce either, and I wonder how this could relate to this commit 042efa0 which is likely the culprit.

If HOME wasn't set, it would now try something else on other platforms, so maybe we should try that only on Windows?

@EliahKagan EliahKagan mentioned this pull request Aug 29, 2025
Merged
@Byron Byron marked this pull request as ready for review August 30, 2025 06:27
@Byron Byron merged commit eee5199 into main Aug 30, 2025
27 checks passed
@Byron Byron deleted the improvements branch August 30, 2025 06:27
@EliahKagan EliahKagan mentioned this pull request Aug 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Byron