Hotfix: use system-provided cyrus-sasl/libsasl2 at runtime #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having multiple builds with and without `libsasl2` on Linux, one of which cannot be redistributed within Python wheels, we use `dlopen` to load `libsasl2` at runtime on Unix. The SASL GSSAPI mechanism availability is thus checked at runtime. Because of differences in soname ABI bumps between Debian-based and RPM-based distros, the previous SASL builds did not work on Debian-based systems. This is also solved in this change, by probing the various known names for `libsasl2`.
This was referenced Aug 14, 2025
marcin-krystianc
approved these changes
Aug 14, 2025
Comment on lines
+86
to
+104
| typedef struct sasl_secret { | ||
| unsigned long len; | ||
| unsigned char data[1]; | ||
| } sasl_secret_t; | ||
|
|
||
| typedef struct sasl_callback { | ||
| unsigned long id; | ||
| int (*proc)(void); | ||
| void *context; | ||
| } sasl_callback_t; | ||
|
|
||
| typedef struct sasl_interact { | ||
| unsigned long id; | ||
| const char *challenge; | ||
| const char *prompt; | ||
| const char *defresult; | ||
| const void *result; | ||
| unsigned len; | ||
| } sasl_interact_t; |
There was a problem hiding this comment.
I've verified that the original structs do not have a packed attribute, so the layout of these copied structs should be the same.
jgiannuzzi
added a commit
to G-Research/confluent-kafka-python
that referenced
this pull request
Aug 15, 2025
- Hotfix: use system-provided cyrus-sasl/libsasl2 at runtime - revert previous approach for universal build that is now obsoleted by G-Research/librdkafka#9 - use `librdkafka.redist` version `2.11.0.1-RC1` - CI: build linux arm64 wheels too - CI: check version consistency - Bump version to `2.11.0.1-RC1+gr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See confluentinc#5168