Adds QoS settings to RabbitMQ message bus #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configures channel QoS (Quality of Service) settings, allowing control over message prefetching. This improves message processing by limiting the number and size of unacknowledged messages a consumer can have. Adds options to configure prefetch count, prefetch size, and global QoS settings.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Quality of Service (QoS) controls to the RabbitMQ message bus, allowing consumers to limit the number and total size of unacknowledged messages, and to apply these limits globally or per channel.
- Added
PrefetchCount,PrefetchSize, andGlobalQosoptions to configure consumer prefetch behavior. - Provided corresponding fluent builder methods in
RabbitMQMessageBusOptionsBuilder. - Updated subscription logic to call
BasicQosAsyncwhen QoS settings are specified and log the applied settings.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Foundatio.RabbitMQ/Messaging/RabbitMQMessageBusOptions.cs | Adds QoS properties and builder methods for prefetch count, size, and global application |
| src/Foundatio.RabbitMQ/Messaging/RabbitMQMessageBus.cs | Calls BasicQosAsync with new options when subscribing and logs the configuration |
Comments suppressed due to low confidence (2)
src/Foundatio.RabbitMQ/Messaging/RabbitMQMessageBus.cs:90
- Add unit tests for the new QoS logic to verify that
BasicQosAsyncis called with the correct parameters across different combinations ofPrefetchCount,PrefetchSize, andGlobalQos.
if (_options.PrefetchCount > 0 || _options.PrefetchSize > 0)
src/Foundatio.RabbitMQ/Messaging/RabbitMQMessageBusOptions.cs:119
- Provide XML documentation comments for the
PrefetchCount,PrefetchSize, andGlobalQosbuilder methods to maintain consistency with other fluent API methods.
public RabbitMQMessageBusOptionsBuilder PrefetchCount(ushort prefetchCount)
| string queueName = await CreateQueueAsync(_subscriberChannel).AnyContext(); | ||
|
|
||
| // Set QoS (Quality of Service) settings for the consumer | ||
| if (_options.PrefetchCount > 0 || _options.PrefetchSize > 0) |
There was a problem hiding this comment.
The condition skips applying QoS when both PrefetchCount and PrefetchSize are zero, even if GlobalQos is true. Consider extending the check to || _options.GlobalQos so that global QoS is always applied when requested.
Suggested change
| if (_options.PrefetchCount > 0 || _options.PrefetchSize > 0) | |
| if (_options.PrefetchCount > 0 || _options.PrefetchSize > 0 || _options.GlobalQos) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures channel QoS (Quality of Service) settings, allowing control over message prefetching. This improves message processing by limiting the number and size of unacknowledged messages a consumer can have. Adds options to configure prefetch count, prefetch size, and global QoS settings.