FEATURE: Support SQL Server (and more?) #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdambekalns
requested review from
robertlemke,
bwaidelich,
kitsunet and
nezaniel
kdambekalns
force-pushed
the
feature/mssql-compatibility
branch
from
3117432 to
1a8faab
Compare
kdambekalns
commented
Jan 19, 2024
bwaidelich
reviewed
Jan 19, 2024
|
BTW, this is (slightly) related, it adds a test that invokes a formerly untested code path: Flowpack/jobqueue-common#62 |
- add return types - add types to method arguments - drop unneeded doc comments
This switches the hard-coded SQL against Doctrine DBAL query builder use. This makes the queue work on SQL Server and potentially more databases supported by Doctrine DBAL.
- simplify query builder use - add some sprintf - rename some variables - amend docblocks
kdambekalns
force-pushed
the
feature/mssql-compatibility
branch
from
1a8faab to
ba14187
Compare
|
Thanks @bwaidelich – I improved the code! |
bwaidelich
approved these changes
Jan 22, 2024
|
Have been testing this the last two days, LGTM. |
bwaidelich
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the hard-coded SQL against Doctrine DBAL query builder use.
This makes the queue work on SQL Server and potentially more databases supported by Doctrine DBAL.