BUGFIX: Make it safe to run setup more than once #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusguenther
approved these changes
Feb 25, 2020
daniellienert
approved these changes
Feb 26, 2020
bwaidelich
reviewed
Nov 19, 2020
| try { | ||
| $this->connection->exec("CREATE INDEX state_scheduled ON {$this->connection->quoteIdentifier($this->tableName)} (state, scheduled)"); | ||
| } catch (Exception $e) { | ||
| // See https://dba.stackexchange.com/questions/24531/mysql-create-index-if-not-exists |
There was a problem hiding this comment.
IMO it's a dangerous pattern to just silently ignore a whole class of exceptions.. IMO we should just catch the exact exception class for the described case and (in the long run) allow the setup to report back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
CREATE INDEX IF NOT EXISTSin MySql, so we need to try/catch to make the operation optional.See https://dba.stackexchange.com/questions/24531/mysql-create-index-if-not-exists
Fixes #12