Skip to content

Conversation

emyller
Copy link
Contributor

@emyller emyller commented Sep 4, 2025

Contributes to Flagsmith/flagsmith#5814

Add a new is_database_replica_setup utility to help avoiding using_database_replica when no replicas are given.

@emyller emyller self-assigned this Sep 4, 2025
@emyller emyller marked this pull request as ready for review September 4, 2025 16:32
@emyller emyller requested a review from a team as a code owner September 4, 2025 16:32
@emyller emyller requested review from gagantrivedi and removed request for a team September 4, 2025 16:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.53%. Comparing base (a21d125) to head (28c3f19).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   94.51%   94.53%   +0.02%     
==========================================
  Files          75       75              
  Lines        2408     2417       +9     
==========================================
+ Hits         2276     2285       +9     
  Misses        132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matthewelwell
matthewelwell previously approved these changes Sep 4, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't have to run this function every time it's called.

matthewelwell
matthewelwell previously approved these changes Sep 4, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emyller emyller merged commit 1c6c522 into main Sep 4, 2025
3 checks passed
@emyller emyller deleted the feat/is-replica-setup branch September 4, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants