-
Notifications
You must be signed in to change notification settings - Fork 2
feat(utils): New is_database_replica_setup utility #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 94.51% 94.53% +0.02%
==========================================
Files 75 75
Lines 2408 2417 +9
==========================================
+ Hits 2276 2285 +9
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't have to run this function every time it's called.
88c2a04
to
28c3f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributes to Flagsmith/flagsmith#5814
Add a new
is_database_replica_setup
utility to help avoidingusing_database_replica
when no replicas are given.