Fixes #601: Jackson subtype schema unions are non-deterministic #613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes: #601)
With the current implementation of the
RecordVisitor
, Avro schema unions are handled in a non-deterministic way. This can cause deserialization errors when differentAvroMapper
instances are used for serialization and deserialization.Specifically, because the subtype ordering is unstable, deserialization may attempt to resolve a serialized object against the wrong subtype, resulting in errors.
This PR makes the ordering deterministic by using an
ArrayList
instead of aSet
, ensuring consistent behavior across serialization and deserialization.