feat: add Google Pay yellow path #40

dbracamonte · 2025-08-29T15:53:02Z

This PR introduces new features to integrate the Google Pay yellow path flow, allowing users to resume adding cards to Google Wallet and managing existing tokens. This is essential to comply with Google Pay requirements.

Summary

Add resumeAddCardToGoogleWallet() method for resuming card provisioning using existing token reference ID
Add listTokens() method to retrieve all tokens stored in Google Wallet
Add new TypeScript types: AndroidResumeCardData and TokenInfo
Update README.md with comprehensive documentation for the new methods

Changes Made

Android Native (Kotlin)

WalletModule.kt: Added resumeAddCardToGoogleWallet and listTokens methods with proper error handling
NativeWalletSpec.java: Added method signatures for the new functionality

TypeScript/React Native

NativeWallet.ts: Added new types and method signatures to the TurboModule spec
index.tsx: Implemented JavaScript wrapper functions with proper platform checks and error handling

Documentation

README.md: Updated API reference table, data types section, and function count

Features

`resumeAddCardToGoogleWallet(cardData: AndroidResumeCardData)`

Resumes card provisioning flow using an existing tokenReferenceId
Simplified data structure compared to full card provisioning
Supports optional cardholder name and last digits for display purposes
Returns TokenizationStatus to track the operation result

`listTokens()`

Retrieves all tokens currently stored in Google Wallet
Returns array of TokenInfo objects containing:
- tokenReferenceId: Unique token identifier
- fpanLastFour: Last four digits of the tokenized card
- tokenState: Current state of the token (numeric value)
Handles empty results gracefully

- add resumeAddCardToGoogleWallet() method for resuming card provisioning using existing token reference ID - add listTokens() method to retrieve all tokens stored in Google Wallet - add AndroidResumeCardData and TokenInfo types for new functionality - update README.md with documentation for new methods These methods provide better token lifecycle management and support for existing card tokens in Google Wallet integration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

github-actions · 2025-08-29T15:53:11Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

dbracamonte · 2025-08-29T15:57:19Z

I have read the CLA Document and I hereby sign the CLA

Skalakid

Overall, it looks good. I've left some comments. Additionally, could you please add a video to the PR description that demonstrates how your solution works in our example app?

Skalakid · 2025-09-01T06:30:16Z

example/src/walletUtils.ts

+
+      if (!existingToken) {
+        throw new Error(
+          `No se encontró el token para la tarjeta terminada en ${CONST.AndroidDummyResumeCardData.lastDigits}`,


Change this error message to english

Suggested change

`No se encontró el token para la tarjeta terminada en ${CONST.AndroidDummyResumeCardData.lastDigits}`,

`Token not found for card ending with ${CONST.AndroidDummyResumeCardData.lastDigits}`,

Skalakid · 2025-09-01T06:34:50Z

src/NativeWallet.ts

@@ -29,6 +29,13 @@ type AndroidCardData = {
  userAddress: UserAddress;
 };

+type AndroidResumeCardData = {
+  network: string;
+  tokenReferenceId: string;


Suggested change

tokenReferenceId: string;

tokenReferenceID: string;

Skalakid · 2025-09-01T06:43:40Z

src/index.tsx

+async function listTokens(): Promise<TokenInfo[]> {
+  if (Platform.OS === 'ios') {
+    throw new Error('listTokens is not available on iOS');
+  }


It would be great to add the listTokens() function also for iOS. Since it's Android-specific PR, how about adding an iOS stub here, and renaming TokenInfo return type keys to be more cross-platform reusable. For example:

type TokenInfo = { identifier: string; lastDigits: string; tokenState: number; };

Thanks to that iOS implementation can be added in a follow-up PR

Skalakid · 2025-09-01T06:48:01Z

src/NativeWallet.ts

+type TokenInfo = {
+  tokenReferenceId: string;
+  fpanLastFour: string;
+  tokenState: number;
+};


As said before, how about renaming keys to something like this:

Suggested change

type TokenInfo = {

tokenReferenceId: string;

fpanLastFour: string;

tokenState: number;

};

type TokenInfo = {

identifier: string;

lastDigits: string;

tokenState: number;

};

Skalakid · 2025-09-01T07:48:16Z

README.md

 | **UserAddress** | Structured address used for cardholder verification. | `name: string`,<br>`addressOne: string`,<br>`addressTwo: string`,<br>`city: string`,<br>`administrativeArea: string`,<br>`countryCode: string`,<br>`postalCode: string`,<br>`phoneNumber: string` |
 | **IOSCardData** | Data related to a card that is to be added on iOS platform. | `network: string`,<br>`activationData: string`,<br>`encryptedPassData: string`,<br>`ephemeralPublicKey: string`,<br>`cardHolderTitle: string`,<br>`cardHolderName: string`,<br>`lastDigits: string`,<br>`cardDescription: string`,<br>`cardDescriptionComment: string` |
 | **onCardActivatedPayload** | Data used by listener to notice when a card’s status changes. | `tokenId: string`,<br> `actionStatus: 'activated' \| 'canceled'`<br> |
 | **IOSIssuerCallback** | This callback is invoked with a nonce, its signature, and a certificate array obtained from Apple. It is expected that you will forward these details to your server or the card issuer's API to securely encrypt the payload required for adding cards to the Apple Wallet. | `(nonce: string, nonceSignature: string, certificate: string[]) => IOSEncryptPayload` |
 | **IOSEncryptPayload** | An object containing the necessary elements to complete the addition of a card to Apple Wallet. | `encryptedPassData: string`,<br>`activationData: string`,<br>`ephemeralPublicKey: string` |
+| **TokenInfo** | Information about a token stored in Google Wallet. | `tokenReferenceId: string`,<br>`fpanLastFour: string`,<br>`tokenState: number` |


Update type value names here too

Skalakid · 2025-09-01T08:53:30Z

android/src/main/java/com/expensify/wallet/WalletModule.kt

+  @ReactMethod
+  override fun resumeAddCardToGoogleWallet(data: ReadableMap, promise: Promise) {
+    try {
+      val tokenReferenceId = data.getString("tokenReferenceId")


Suggested change

val tokenReferenceId = data.getString("tokenReferenceId")

val tokenReferenceID = data.getString("tokenReferenceID")

dbracamonte · 2025-09-01T19:47:10Z

Overall, it looks good. I've left some comments. Additionally, could you please add a video to the PR description that demonstrates how your solution works in our example app?

Thanks for the review!

Regarding the demo video, I need to clarify the testing constraints:

To demonstrate the Google Pay tokenization flow, I would need:

Production certificates from Google Pay (which I don't currently have access to)
Google-authorized test cards for the sandbox environment

The testing I performed was done using my work environment, but I cannot share that footage publicly as it contains
proprietary information from an unreleased application.

dbracamonte · 2025-09-04T14:03:33Z

Greetings @Skalakid, I'm looking forward to continuing the approval process. If there's any way I can proceed, please let me know.

Skalakid · 2025-09-05T09:36:01Z

Hello, had to finish some other tasks. We need to check if it actually works before merging. Since you've tested it in your unreleased app and can't attach a video here, I think we can try testing it in the Expensify app. I will try to add this flow there and will come back to you with more information

Skalakid

@dbracamonte Finally got some time to test this PR. Everything works fine. Left some last comments, and I think we can merge it ;)

yellow-path.mp4

Skalakid · 2025-09-16T10:58:33Z

android/src/main/java/com/expensify/wallet/WalletModule.kt

+
+      val cardNetwork = getCardNetwork(network)
+      val tokenServiceProvider = getTokenServiceProvider(network)
+      val displayName = getDisplayName(data, network)


Why can't we use just cardHolderName as a display name, like in the addCardToGoogleWallet function? Is the getDisplayName function necessary?

Skalakid · 2025-09-16T10:58:52Z

android/src/main/java/com/expensify/wallet/WalletModule.kt

+    }
+
+    return "${network.uppercase(Locale.getDefault())} Card"
+  }


According to the above comment, why do we need this?

melvin-bot bot assigned dbracamonte Aug 29, 2025

CLABotify added a commit to Expensify/CLA that referenced this pull request Aug 29, 2025

@dbracamonte has signed the CLA in Expensify/react-native-wallet#40

ba1eb1c

dbracamonte changed the title ~~feat: add Google Wallet token management methods~~ feat: add Google Pay yellow path Aug 29, 2025

dbracamonte mentioned this pull request Aug 29, 2025

Android Google Pay yellow path #33

Open

feat(android): add resumeAddCardToGoogleWallet example code

05047f2

Skalakid requested review from Skalakid and zfurtak September 1, 2025 06:25

Skalakid requested changes Sep 1, 2025

View reviewed changes

Skalakid reviewed Sep 1, 2025

View reviewed changes

dbracamonte added 2 commits September 1, 2025 12:20

feat(types): rename TokenInfo fields for cross-platform compatibility

b5adf15

feat: add stub for listTokens on iOS, returning an empty array

4e12e45

Skalakid reviewed Sep 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add Google Pay yellow path #40

feat: add Google Pay yellow path #40

Uh oh!

dbracamonte commented Aug 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 29, 2025 •

edited

Loading

Uh oh!

dbracamonte commented Aug 29, 2025

Uh oh!

Skalakid left a comment

Uh oh!

Skalakid Sep 1, 2025

Uh oh!

Skalakid Sep 1, 2025

Uh oh!

Skalakid Sep 1, 2025 •

edited

Loading

Uh oh!

Skalakid Sep 1, 2025

Uh oh!

Skalakid Sep 1, 2025

Uh oh!

Skalakid Sep 1, 2025

Uh oh!

dbracamonte commented Sep 1, 2025

Uh oh!

dbracamonte commented Sep 4, 2025

Uh oh!

Skalakid commented Sep 5, 2025 •

edited

Loading

Uh oh!

Skalakid left a comment •

edited

Loading

Uh oh!

Skalakid Sep 16, 2025

Uh oh!

Skalakid Sep 16, 2025

Uh oh!

Uh oh!

	`No se encontró el token para la tarjeta terminada en ${CONST.AndroidDummyResumeCardData.lastDigits}`,
	`Token not found for card ending with ${CONST.AndroidDummyResumeCardData.lastDigits}`,

	val tokenReferenceId = data.getString("tokenReferenceId")
	val tokenReferenceID = data.getString("tokenReferenceID")

feat: add Google Pay yellow path #40

Are you sure you want to change the base?

feat: add Google Pay yellow path #40

Uh oh!

Conversation

dbracamonte commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Android Native (Kotlin)

TypeScript/React Native

Documentation

Features

resumeAddCardToGoogleWallet(cardData: AndroidResumeCardData)

listTokens()

Uh oh!

github-actions bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbracamonte commented Aug 29, 2025

Uh oh!

Skalakid left a comment

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

dbracamonte commented Sep 1, 2025

Uh oh!

dbracamonte commented Sep 4, 2025

Uh oh!

Skalakid commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Skalakid left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbracamonte commented Aug 29, 2025 •

edited

Loading

`resumeAddCardToGoogleWallet(cardData: AndroidResumeCardData)`

`listTokens()`

github-actions bot commented Aug 29, 2025 •

edited

Loading

Skalakid Sep 1, 2025 •

edited

Loading

Skalakid commented Sep 5, 2025 •

edited

Loading

Skalakid left a comment •

edited

Loading