Call inference refactor #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taminomara
force-pushed
the
call_inference_refactor
branch
from
8c1681c to
4316392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #462.
Due to renames, PR's diff is a mess. The significant changes are in the first commit, the rest are just renames.
Apart from unions and intersections I've found two places where the logic differs:
infer_type_doc_functiondidn't handleselfsubstitutions,infer_signature_doc_functiondidn't defer inference to unresolve stage.Additionally, there are two more significant changes:
infer_call_exprnow commits inference to cache, so that diagnostics can reuse the results,unwrapp_return_typebefore it is committed.Other that that, the functionality should be the same.