Fix CRLF Injection in AsyncWebHeader.cpp (GHSA-87j8-6f7g-h8wh) #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
changed the title
mathieucarbou
commented
Jun 27, 2025
| log_v("Invalid character in HTTP header"); | ||
| #endif | ||
| return; // Invalid header format | ||
| } |
There was a problem hiding this comment.
@me-no-dev : the current code is weird IMO. If the header line cannot be parsed in anyway, we should not have created a AsyncWebHeader instance from start. This parsing logic should be extracted in a static method which is returning an AsyncWebHeader pointer or null maybe.
WDYT ?
There was a problem hiding this comment.
we could rethink the logic, agreed
There was a problem hiding this comment.
Ok. Let's merge that, cut a release, then do the change
me-no-dev
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.